search

dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

Venn, Sequence Sun Burst & Geo Spatial diagrams #132

Closed maqboolkhan closed 5 years ago

maqboolkhan commented 5 years ago

This branch was also presented to our Historian group

codecov-io commented 5 years ago

Codecov Report

Merging #132 into master will decrease coverage by 2%. The diff coverage is 6.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
- Coverage      39.6%   37.59%   -2.01%     
- Complexity      132      153      +21     
============================================
  Files            48       52       +4     
  Lines          1212     1423     +211     
  Branches        134      156      +22     
============================================
+ Hits            480      535      +55     
- Misses          704      860     +156     
  Partials         28       28
Impacted Files Coverage Δ Complexity Δ
...s/src/main/java/upb/ida/venndiagram/VENN_Util.java 7.14% <0%> (ø) 1 <0> (ø) :arrow_down:
.../java/upb/ida/provider/RiveScriptBeanProvider.java 100% <100%> (ø) 2 <0> (ø) :arrow_down:
.../main/java/upb/ida/provider/SSBDiagramHandler.java 5% <5%> (ø) 1 <1> (?)
...c/main/java/upb/ida/provider/DataDumpProvider.java 100% <0%> (ø) 14% <0%> (+9%) :arrow_up:
...da-ws/src/main/java/upb/ida/bean/ResponseBean.java 58.82% <0%> (ø) 7% <0%> (?)
...da-ws/src/main/java/upb/ida/util/BarGraphUtil.java 1.12% <0%> (ø) 1% <0%> (?)
...in/java/upb/ida/serializer/RespBeanSerializer.java 0% <0%> (ø) 0% <0%> (?)
...ain/java/upb/ida/bean/cluster/ClusterAlgoDesc.java 41.66% <0%> (+4.16%) 4% <0%> (+1%) :arrow_up:
...da-ws/src/main/java/upb/ida/util/DataDumpUtil.java 85.71% <0%> (+7.14%) 5% <0%> (+1%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef95cfd...b8b10ac. Read the comment docs.

maqboolkhan commented 5 years ago

this PR is ready I double check it, it can be merged it right away

maqboolkhan commented 5 years ago

Thanks, @Cortys but I guess every visualization is data dependent somehow. For example, let's say a simple diagram like Venn diagram will not work also if provided data has nothing common. I believe @nikit91 can comment better.

Thanks cc @nikit91

nikit-srivastava commented 5 years ago

Hi @maqboolkhan , Visualizations should be data agnostic and should only have dependency on type of values they could accept.

At the time of development the visualizations were mostly made to target a particular use-case. However, most of the visualizations now can also handle different use cases as well.

In my opinion, we should refactor our variables and methods (if any) to carry generic names.

maqboolkhan commented 5 years ago

Thanks, I am done with refactoring the names

cc @Cortys

maqboolkhan commented 5 years ago

Thanks again @Cortys done