dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

fixed most of vulnerabilities with NPM audit fix #144

Closed maqboolkhan closed 5 years ago

maqboolkhan commented 5 years ago

I used npm audit fix command to fix vulnerabilities. It fixed every vulnerability except two and these are from Angular packages (Dev dependencies). npm audit fix updated bunch of packages so I tested UI with data set loading & bar chart creation, fortunately, everything working flawlessly.

codecov-io commented 5 years ago

Codecov Report

Merging #144 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #144   +/-   ##
=========================================
  Coverage     43.24%   43.24%           
  Complexity      155      155           
=========================================
  Files            49       49           
  Lines          1274     1274           
  Branches        139      139           
=========================================
  Hits            551      551           
  Misses          684      684           
  Partials         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 411f25d...db74642. Read the comment docs.

nikit-srivastava commented 5 years ago

@maqboolkhan is there anybody in the team that could perform manual test for verification? (possibly someone from the new team members, as it might help them understand the functionality)

maqboolkhan commented 5 years ago

@RahulSherikar @nandeeshpatelgp please pull this branch and run IDA and perform UI operations with IDA chat bot & if everything works or anything breaks just comment here. As Nikit said its a good opportunity to learn how IDA works. Thanks

RahulSherikar commented 5 years ago

@RahulSherikar @nandeeshpatelgp please pull this branch and run IDA and perform UI operations with IDA chat bot & if everything works or anything breaks just comment here. As Nikit said its a good opportunity to learn how IDA works. Thanks

Sure will do, Thanks

RahulSherikar commented 5 years ago

@RahulSherikar @nandeeshpatelgp please pull this branch and run IDA and perform UI operations with IDA chat bot & if everything works or anything breaks just comment here. As Nikit said its a good opportunity to learn how IDA works. Thanks

Hi Maq, Followed your sent instructions to chat with the chatbot to perform below things, since the chatbot understands only a few sets of instructions,

  1. Load dataset query
  2. Requesting BarGraph
  3. Requesting Force-Directed Graph
  4. Clustering

found no issues in points 1,2 and 3 but I'm getting some kind of error for point 4 and the clustering is not getting plotted as shown below IDA Clustering error

Still will explore into the chatbot to understand how it works and so on.

Thanks.