Closed AsjadLFC closed 5 years ago
Merging #153 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #153 +/- ##
=========================================
Coverage 43.24% 43.24%
Complexity 155 155
=========================================
Files 49 49
Lines 1274 1274
Branches 139 139
=========================================
Hits 551 551
Misses 684 684
Partials 39 39
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0d3b183...1eeb018. Read the comment docs.
Hi @AsjadLFC @tohardik,
Good Work 👍 but you guys committed ttl file of classified data
please remove it asap
@maqboolkhan I just checked and confirm that the ttl files have only ontology definitions (no sensitive data). I was instructed to keep versioned files of ontology definition checked-into the repository.
@Cortys check this out https://support.codacy.com/hc/en-us/articles/360005097654-Ignore-files-from-Codacy-analysis It is possible to ignore one file from Codacy check. But I am not seeing the "Settings" option when I open ida's Codacy page. Perhaps I do not have access to it. Can you please check?
@tohardik You are right, Codacy is currently set up via @nikit91's account so we cannot reconfigure it. We should probably use a Codacy organization instead to allow multiple team members to change settings. @nikit91 what do you think?
For your specific problem however, the .codacy.yaml
configuration file should also allow you to exclude files via the exclude_paths
property. Maybe try that first.
@Cortys I believe the problem is solved for now, but yes we need to start using the codacy organization. I will try to get this project added to the DICE group's codacy.
@tohardik @AsjadLFC this PR is ready to be merged but i remember Definition fileswere committed into the
Git` and now you have removed them I just want to ask have you guys removed them from Git history as well?
After removing them from Git history kindly comment here so we will merge this PR
Best
@maqboolkhan the purging from history is done. The branch is clean now. You can go ahead with merging.
@Cortys I contacted the support team and they've fixed the force-push notification. I think we can go ahead now.