search

dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

Speech to text #162

Closed aliazmi68 closed 5 years ago

aliazmi68 commented 5 years ago
maqboolkhan commented 5 years ago

LGTM but we need @nikit91 views on it.

maqboolkhan commented 5 years ago

@aliazmi68 As PR is good but I still remember that there were some challenges with this feature I would kindly request you to mention all the challenges here in the comment so it would be helpful in the future for references! and then we will merge this PR

Thanks Best

maqboolkhan commented 5 years ago

@aliazmi68 i merged your PR but please dont forget to post things i asked in last comment!

aliazmi68 commented 5 years ago

I have already mentioned the abstract problems in the first comment. This feature still needs some improvement because the main problem is related to table names. If the table name is complex then It will be difficult to pronounce it. Moreover If the table name contains the underscore '' then during the speech to text conversion it will be converted to the word 'underscore' and not '' . Also this feature is currently set to understand only English language but it can be configured easily to understand German or any other language.