search

dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

Add storycreation to demo #169

Closed Cortys closed 5 years ago

Cortys commented 5 years ago

The storycreation feature is not compatible with the demo branch. It appears to be primarily in conflict with the springsecurity feature. The issue is caused by 37ecb7d4d91aca260e92bcccd149e8455414f007 where you reverted the springsecurity changes. Please revert this reversion and fix any problems that might arise from that. @aliazmi68 @maqboolayaz Please take a look.

codecov-io commented 5 years ago

Codecov Report

Merging #169 into demo/ss19 will decrease coverage by 13.01%. The diff coverage is 24.19%.

Impacted file tree graph

@@               Coverage Diff                @@
##             demo/ss19     #169       +/-   ##
================================================
- Coverage           38%   24.98%   -13.02%     
+ Complexity         183      142       -41     
================================================
  Files               61       64        +3     
  Lines             1584     1681       +97     
  Branches           156      163        +7     
================================================
- Hits               602      420      -182     
- Misses             946     1238      +292     
+ Partials            36       23       -13
Impacted Files Coverage Δ Complexity Δ
.../main/java/upb/ida/rest/MessageRestController.java 55.55% <ø> (+2.61%) 2 <0> (ø) :arrow_down:
.../java/upb/ida/provider/RiveScriptBeanProvider.java 100% <100%> (ø) 2 <2> (ø) :arrow_down:
...a-ws/src/main/java/upb/ida/provider/ScHandler.java 11.11% <11.11%> (ø) 1 <1> (?)
.../src/main/java/upb/ida/util/StoryCreationUtil.java 17.39% <17.39%> (ø) 2 <2> (?)
...-ws/src/main/java/upb/ida/service/DataService.java 3.84% <3.84%> (-8.66%) 1 <1> (ø)
...rc/main/java/upb/ida/rest/StoryRestController.java 8.69% <8.69%> (ø) 2 <2> (?)
.../main/java/upb/ida/provider/ClusterDataGetter.java 1.33% <0%> (-84%) 1% <0%> (-11%)
.../src/main/java/upb/ida/util/CodeGeneratorUtil.java 4.34% <0%> (-82.61%) 1% <0%> (-4%)
...java/upb/ida/provider/UserParamValueCollector.java 3.03% <0%> (-72.73%) 1% <0%> (-6%)
...ain/java/upb/ida/provider/CheckParamCollected.java 3.03% <0%> (-69.7%) 1% <0%> (-4%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f1847d...2eedf30. Read the comment docs.