Closed maqboolkhan closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@91f5b73
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #78 +/- ##
========================================
Coverage ? 7.28%
Complexity ? 42
========================================
Files ? 47
Lines ? 1276
Branches ? 146
========================================
Hits ? 93
Misses ? 1183
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 91f5b73...10497b0. Read the comment docs.
We don't need this PR any more as its old approach and now we have https://github.com/dice-group/ida/pull/111 for the same purpose.
Marking it close
CC: @AsjadLFC @nikit91
Not deleting branch for safe side we can delete it after #111 got merge in master
successfully!
I raised this PR so we can keep track our progress and it will also let our seniors and supervisors review our code so far. When I and @AsjadLFC will be done with it we will remove [WIP] flag. Asjad and I will extract sub branches from it.
Thanks
TODOs