search

dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

Jupyter kernel setup guide #99

Closed faisal07m closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #99 into master will increase coverage by 15.33%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #99       +/-   ##
=============================================
+ Coverage      7.34%   22.68%   +15.33%     
- Complexity       43      107       +64     
=============================================
  Files            48       54        +6     
  Lines          1279     1468      +189     
  Branches        146      165       +19     
=============================================
+ Hits             94      333      +239     
+ Misses         1185     1123       -62     
- Partials          0       12       +12
Impacted Files Coverage Δ Complexity Δ
...c/main/java/upb/ida/provider/DataDumpProvider.java 100% <0%> (ø) 14% <0%> (+5%) :arrow_up:
...s/src/main/java/upb/ida/venndiagram/VENN_ITEM.java 0% <0%> (ø) 0% <0%> (?)
...s/src/main/java/upb/ida/venndiagram/VENN_Util.java 7.14% <0%> (ø) 1% <0%> (?)
.../java/upb/ida/venndiagram/VENN_DATA_GENERATOR.java 0% <0%> (ø) 0% <0%> (?)
.../main/java/upb/ida/provider/GeoDiagramHandler.java 3.44% <0%> (ø) 1% <0%> (?)
...main/java/upb/ida/provider/VennDiagramHandler.java 7.69% <0%> (ø) 1% <0%> (?)
...ain/java/upb/ida/venndiagram/VENN_DATA_FILTER.java 0% <0%> (ø) 0% <0%> (?)
...ain/java/upb/ida/bean/cluster/ClusterAlgoDesc.java 37.5% <0%> (+8.33%) 3% <0%> (+2%) :arrow_up:
ida-ws/src/main/java/upb/ida/util/FileUtil.java 34.78% <0%> (+14.41%) 7% <0%> (+4%) :arrow_up:
...da-ws/src/main/java/upb/ida/temp/ExampleMacro.java 16.66% <0%> (+16.66%) 1% <0%> (+1%) :arrow_up:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d94bd8...73994a5. Read the comment docs.

nikit-srivastava commented 5 years ago

@RicardoUsbeck what do you think?

RicardoUsbeck commented 5 years ago

I would remove the comments from the README.md inline code, e.g." ## Install using conda " to make it easier to copy things but the rest lgtm

nikit-srivastava commented 5 years ago

@faisal07m please look into the requested changes