search

dice-group / owlapy

OWLAPY is a Python Framework for creating and manipulating OWL Ontologies.
MIT License
21 stars 2 forks source link

Refactor structural reasoner #100

Closed LckyLke closed 2 weeks ago

LckyLke commented 2 weeks ago

Refactoring for Issue #98

Demirrr commented 2 weeks ago

Can you please add few tests ?

alkidbaci commented 2 weeks ago

I was hoping we could discuss this stuff about StructuralReasoner on Monday before doing any changes

Demirrr commented 2 weeks ago

Sorry, I don't think there is a need to discuss about these changes. We haven't discussed using LRUCache but this seems to be integrated which I haven't seen it

alkidbaci commented 2 weeks ago

We haven't discussed using LRUCache but this seems to be integrated which I haven't seen it

I have not integrated LRUCache, it has been there since the time of Simon Bin and Lukas and I'm not against removing it