search

dice-group / sask

Projectgroups Search and Extraction
GNU Affero General Public License v3.0
2 stars 10 forks source link

Chatbot junit test #31

Closed Juzerhk closed 6 years ago

guruprasads7 commented 6 years ago

@Juzerhk , The build is failing due to your test cases. Please correct this

Juzerhk commented 6 years ago

The tests are able to pass now. It was getting fail earlier because of the issue "BugFix: Call to load resources was missed out" of commit id : cfafc141a2db5bebdeb01a4e2b8d34c8bdca6ae7 As this issue is resolved now. The test are passing and we can merge

Juzerhk commented 6 years ago

removed sysouts and unwanted log info

prasanthhs commented 6 years ago

Not sure why it shows this comment is outdated but let me put it again.

RiveScriptOutputAnalyzerTest.java "This entire file is commented now. You mentioned that other bug fix by @guru5590(Pull Request #33 ) fixes this issue. Then this file can be uncommented and it should work well? Please check if all the functions can be uncommented."

Juzerhk commented 6 years ago

@prasanthhs The commit from guru solved the issue for classifier test. This test cases belongs to RiveScriptOutputAnalyser and not to the classifier. The reason it is commented because the test cases where written for thefunctions which no longer exist in the same file and the RiveScriptOutputAnalyser file is modified and some fuctions are moved to some other file. Hence these test cases needs to be rewritten and as per the latest file. I am working on it and this would be done very soon

prasanthhs commented 6 years ago

@Juzerhk Please also look into the codacy failures which your last check in caused. There are eleven issues present under Codacy/PR Quality Review.

And, please remove the file if the entire file is to be commented since its a new file to be merged to master. Please also use / and / for commenting a code block, not single line comments(using //) as its difficult to uncomment them on command line terminal. Please also revert Sessa test case.

Juzerhk commented 6 years ago

@prasanthhs removed log files and unused imports.

Juzerhk commented 6 years ago

@AndreSonntag Those multiple enteries are removed.

prasanthhs commented 6 years ago

@Juzerhk Can you please verify the files you've checked in by test case? Are you sure this is correct line in template.yml file? The file has "---" at the beginning. Please do a basic sanity test of your changes by manual UI test. Kindly do not check in files without test since these kind of check-in issues get missed.

And the issues of Codacy still shows 7 issues including 2 unused imports. Please check them again.

Juzerhk commented 6 years ago

The template.yml file is excatly the same as it is in the master
branch. So I think that#s the correct one. I will do the manual
testing and sanity check.

Quoting Prashanth notifications@github.com:

@Juzerhk Can you please verify the files you've checked in by test
case? Are you sure this is correct line in template.yml file? The
file has "---" at the beginning. Please do a basic sanity test of
your changes by manual UI test if possible.

And the issues of Codacy still shows 7 issues including 2 unused
imports. Please check them again.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/dice-group/sask/pull/31#issuecomment-384039308

prasanthhs commented 6 years ago

@Juzerhk there is just the one codify issue now. If you can fix it, we can merge this change. The other changes seem OK.

Juzerhk commented 6 years ago

I have fixed all the issues now. please have a look

Quoting Prashanth notifications@github.com:

@Juzerhk there is just the one codify issue now. If you can fix it,
we can merge this change. The other changes seem OK.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/dice-group/sask/pull/31#issuecomment-384221153