dice-group / sask

Projectgroups Search and Extraction
GNU Affero General Public License v3.0
2 stars 10 forks source link

Bug fix null input query handling #39

Closed divyasrinivasan1986 closed 6 years ago

divyasrinivasan1986 commented 6 years ago

HTML, Java script changes Handle empty query String in classifier to ensure it doesnt return any viable class. Removed logs in JS code.

guruprasads7 commented 6 years ago

@divyasrinivasan1986 , The Issue still remains. Now the Send button is irresponsive, post entering the input in the text box

screen shot 2018-04-27 at 15 55 36
divyasrinivasan1986 commented 6 years ago

@guru5590 This may be an issue with your cache. I checked again by downloading code from my branch and on the vm and it seems to work fine. Can you please check again after clearing cache(or the code is also present in VM in a. folder under my name which can also be used)?

guruprasads7 commented 6 years ago

@divyasrinivasan1986 , You were right it was my cache issue. The send button is working as expected :)

Don't feel like I'm nagging you. But in the text box, if I do a double enter, still the no input is accepted :(

Attached is the sceenshots:

1) Intial state

screen shot 2018-04-27 at 16 49 07

2) First time carriage return is pressed

screen shot 2018-04-27 at 16 49 23

3) Second time carriage return is pressed

screen shot 2018-04-27 at 16 49 34
divyasrinivasan1986 commented 6 years ago

@guru5590 I think the issue is because second carriage return is treated as a non-empty string. If we trim the input string to eliminate the white space on either side of the string, it should solve the problem. I will update the code accordingly.

guruprasads7 commented 6 years ago

This commit, fixes the issue. Hence merging the code to master branch