search

dice-group / sask

Projectgroups Search and Extraction
GNU Affero General Public License v3.0
2 stars 10 forks source link

Chatbot doesn't handle "bye" as an input #43

Closed guruprasads7 closed 6 years ago

guruprasads7 commented 6 years ago

Chatbot returns an exception, when handling "bye" as an input.

Attached is the screenshot of the exception:

screen shot 2018-04-30 at 10 48 03

Also, the log from the backend:

screen shot 2018-04-30 at 10 49 04

P.S: Thanks Juzer for help identifying the issue.

Juzerhk commented 6 years ago
chatbot_bye

ChatBot is now able to handle Bye Response

guruprasads7 commented 6 years ago

@Juzerhk , Where is the code fixing this issue. I have not seen a pull request.

@Juzerhk , Please note , the issue can only be closed, when the code is reviewed and mergred into the master branch. And the issue ideally should be closed by the one who created the issue, not the one who was assigned the issue ( You in this case)

Juzerhk commented 6 years ago

This issue can easliy be fixed by making a small change in rivescript. So I made made changes in the rivescript rather then changing the code and that is what I have pushed it and now it is working fine.Regarding closing of the ticket, I will keep that in mind.On 6 May 2018 16:42, GuruPrasad notifications@github.com wrote:@Juzerhk , Where is the code fixing this issue. I have not seen a pull request. @Juzerhk , Please note , the issue can only be closed, when the code is reviewed and mergred into the master branch. And the issue ideally should be closed by the one who created the issue, not the one who was assigned the issue ( You in this case)

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

guruprasads7 commented 6 years ago

@Juzerhk If the code fix is in place. Please raise a pull request, so we can review the changes.

As mentioned, before once the fix is merged to the master branch. We will close this issue.

prasanthhs commented 6 years ago

@guru5590 Sorry to interrupt.

@Juzerhk Your fix is not scalable. Can you please look at a more permanent fix? Clearly the JSON parser says its a valid JSON input if your input is a single word, which is the cause for this issue because its not JSON. Changing the rive script to reply two words is fine for this use case as it takes care of this very particular scenario. But what about other inputs with one word reply from rivescript? Again similar issue should happen?

guruprasads7 commented 6 years ago

@Juzerhk, the code changes you have made, just fixes the current issue. But it doesn't cover all scenarios as your masking a library issue with your code. I'll be closing this one, but in future a bug can be caused coz of this.