search

dice-group / sask

Projectgroups Search and Extraction
GNU Affero General Public License v3.0
2 stars 10 forks source link

Database ms #68

Closed Suganya31 closed 6 years ago

Suganya31 commented 6 years ago

In this pull request, update and query a named graph functionality as well as a method to process sparql query is added to database microservice. Also we add a method to get the name of all graphs from the database. According to search group request the updateAutoIndex method added to send a copy of all triples in database to AutoIndex.

prasanthhs commented 6 years ago

@Suganya31 Can you please fix the Codacy issues before merge since @idreestahir already has many issues left. There are only 4 issues in total so it won't take much time. Click on details next to Codacy and it will tell what those issues are and what would be the proposed changes.

Edit: You've already done it. Thanks

Suganya31 commented 6 years ago

@prasanthhs Will you be considering the solutions provided by @KHaack or should we disable the test?

prasanthhs commented 6 years ago

@Suganya31 it is fine to disable the tests for now. Probably, the permanent solution should be to start fuseki from code, or one of the two options provided by @KHaack so that travis will not always show compilation error.

Example of starting Fuseki from Code: https://github.com/apache/jena/blob/master/jena-fuseki2/jena-fuseki-embedded/src/test/java/org/apache/jena/fuseki/embedded/TestEmbeddedFuseki.java

KHaack commented 6 years ago

currently we dont want to make integration tests on travis