search

dice-group / sask

Projectgroups Search and Extraction
GNU Affero General Public License v3.0
2 stars 10 forks source link

Keyword search #84

Closed Muzammil1234 closed 6 years ago

Muzammil1234 commented 6 years ago

mergin keyword-search

prasanthhs commented 6 years ago

@Muzammil1234 There is still a .iml file left which should be removed (keyword-search/KeywordSearch.iml). Is this file required?

@guru5590 Can you please check if this can be moved to master branch? I am not sure this folder should be included in compilation on parent pom level.

guruprasads7 commented 6 years ago

@Muzammil1234, please try to use the same spring boot version as defined in the parent Pom.xml.

The resources are accessed via hard coded windows path, this should not be there.

Also, there are two main methods in different classes.

prasanthhs commented 6 years ago

@guru5590 Lets just export to master branch (as long as it doesn't affect other components) and keep this as a future issue. I think, for this, we should remove keyword-search from parent pom. Any other suggestions?

prasanthhs commented 6 years ago

@Muzammil1234 Please remove KeywordSearch.iml and compilation of keyword search from pom.xml.

Muzammil1234 commented 6 years ago

i have done it! i am pushing it on git

On Sun, Jul 15, 2018, 17:52 Prashanth notifications@github.com wrote:

@Muzammil1234 https://github.com/Muzammil1234 Please remove KeywordSearch.iml and compilation of keyword search from pom.xml.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dice-group/sask/pull/84#issuecomment-405100458, or mute the thread https://github.com/notifications/unsubscribe-auth/AVsJ3n__8zp9VQhr2YMd3P0MbKcQU5eeks5uG2U9gaJpZM4VPX6o .

Muzammil1234 commented 6 years ago

The main methods will remain there! The main method in keyword_web_service will be used for starting webservice

On Sun, Jul 15, 2018, 17:53 muzammil ahmed muzammil.bravo@gmail.com wrote:

i have done it! i am pushing it on git

On Sun, Jul 15, 2018, 17:52 Prashanth notifications@github.com wrote:

@Muzammil1234 https://github.com/Muzammil1234 Please remove KeywordSearch.iml and compilation of keyword search from pom.xml.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dice-group/sask/pull/84#issuecomment-405100458, or mute the thread https://github.com/notifications/unsubscribe-auth/AVsJ3n__8zp9VQhr2YMd3P0MbKcQU5eeks5uG2U9gaJpZM4VPX6o .

prasanthhs commented 6 years ago

@guru5590 If this is OK, please confirm and export.

Muzammil1234 commented 6 years ago

i have already deleted the commented module and pushed it on github

On Sun, Jul 15, 2018, 18:29 Prashanth notifications@github.com wrote:

@guru5590 https://github.com/guru5590 If this is OK, please confirm and export.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dice-group/sask/pull/84#issuecomment-405102522, or mute the thread https://github.com/notifications/unsubscribe-auth/AVsJ3uXOuvVSE9NIZylff_UN0qW8pUKjks5uG235gaJpZM4VPX6o .