Closed guruprasads7 closed 6 years ago
@guru5590 There is a deploy_rsa.enc file which is of type binary.
/root/sask_hadoop_settings.sh-> Where is this file?
@prasanthhs, sask_hadoop_settings.sh from the repository will be copied on to the host system where hadoop will be deployed and its volume mounted into the docker container. It was missed out, I added it in a new commit.
deploy_rsa.enc travis encrypted private key file, which will be used to ssh into the host where the docker containers will be deployed. This file is used to create a trust between the travis ci with the node which is used for deployment.
@guru5590 Seems OK. But @RicardoUsbeck mentioned, please update ReadMe and wiki, Wiki for the code coverage change you have done and if any changes are required to the demo put on wiki/playbook Read Me, then please change them as well.
:exclamation: No coverage uploaded for pull request base (
master@2249fc3
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
Coverage ? 34.63%
Complexity ? 225
=========================================
Files ? 68
Lines ? 2128
Branches ? 181
=========================================
Hits ? 737
Misses ? 1320
Partials ? 71
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2249fc3...a4522da. Read the comment docs.
@prasanthhs , I have captured the codecov details in a wiki page... Can I go ahead and merge this request?
1) Integrated with codecov for code coverage stats. 2) The deployment scripts are called as part of the travis continuous integration. The ansible playbooks for create docker image and deploying them are triggered only on the master branch. This can be changed easily based on parameters.
P.S: Sorry for many commits, coz it was an experimenting phase which could have been tested only when pushed to github.