search

dice-roller / rpg-dice-roller

An advanced JS based dice roller that can roll various types of dice and modifiers, along with mathematical equations.
https://dice-roller.github.io/documentation
MIT License
237 stars 57 forks source link

[Bug]: mathjs version produces build warning #295

Open kamejosh opened 3 months ago

kamejosh commented 3 months ago

Description

rpg-dice-roller v5.5.0 uses an old version of mathjs which in combination with produces the following errors when building with vite:

node_modules/mathjs/lib/esm/entry/configReadonly.js (6:20): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/entry/configReadonly.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/type/unit/physicalConstants.js (47:0): A comment

"// export const createSpectralRadiance = /* #__PURE__ */ unitFactory('spectralRadiance', '1.1910429723971881e-16', 'W m^2 sr^-1') // TODO spectralRadiance"

in "node_modules/mathjs/lib/esm/type/unit/physicalConstants.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (24:18): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (39:18): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (48:19): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (57:19): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (70:18): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (94:19): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

This error should be fixed in mathjs Version v12.3.1: https://github.com/josdejong/mathjs/issues/3114#issuecomment-1921076759

Dice Roller version

v5.5.0

Bundle type

ESM

Node version

v20.12.2

Browser name and version

-

kamejosh commented 2 months ago

Is there an update for it, would you allow a PR if I'd provide it?

GreenImp commented 2 months ago

Sorry, I've not had the chance to have a look yet. PRs are always welcome though!