diced / dlauncher

An application launcher for Linux that is based on Ulauncher
GNU General Public License v3.0
83 stars 5 forks source link

Attempting to grab a uLauncher theme and use it caused panics #6

Open MostHated opened 2 years ago

MostHated commented 2 years ago

Hey there, I just wanted to report that since I saw that ulauncher skins were able to be used, I tried to grab one and placed it into the themes folder along side the default theme, but every one of them that I tried (about 6 different ones) all panic'd and closed the dlauncher app I had running in the background upon trying to use dlauncher-toggle.

An example is:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/launcher/util/config.rs:195:6

When attempting to use: https://github.com/fealv/Yaru-dark-ulauncher

I didn't dig too much into it and just took the default one and changed the values, but it looked like the default had additional files not present in any of the ones I had tried using, namely the "reset.css". Not sure if that happens to be related.

Side question, are there any plans on including/creating a small example extension? I would not mind having a go at playing around with one, just to see what I can learn from it, etc.

Thanks, -MH

diced commented 2 years ago

Due to some under thinking I made it so that the name inside of the theme's manifest must be the same as the directory name. So in yaru theme it says yaru-dark and thats what the directory name should be, I'll probably change this later.

On extensions, yes I am working on an example extension, I will probably push it to https://github.com/diced/dlauncher-extension/ later tonight so keep an eye on that.

diced commented 2 years ago

Update: The https://github.com/diced/dlauncher-extension/ repo exists now and feel free to check it out, have fun!

avently commented 2 years ago

The problem with this theme (and similar) is a lack of dark theme in DLauncher the theme is based upon. I copied it from ULauncher source to ~/.config/dlauncher/themes/dark and my theme is working.

TophC7 commented 1 year ago

The problem with this theme (and similar) is a lack of dark theme in DLauncher the theme is based upon. I copied it from ULauncher source to ~/.config/dlauncher/themes/dark and my theme is working.

thir fixed the issue for me thanks! this should be added by default to dlauncher