Bug: `/api/upload` always returns 200

diced / zipline

A ShareX/file upload server that is easy to use, packed with features, and with an easy setup!

https://zipline.diced.sh/

MIT License

1.31k stars 128 forks source link

Bug: `/api/upload` always returns 200 #512

Closed RappyTV closed 8 months ago

RappyTV commented 8 months ago

What happened?

The route always returns 200 and puts the real status code in the body. I would really appreciate if you could return the real status code and also if you'd capitalize the error messages :)

Version

latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)

What browser(s) are you seeing the problem on?

No response

Zipline Logs

No response

Browser Logs

No response

Additional Info

No response

diced commented 8 months ago

Seems fine to me, here are some examples: (putting in values that will cause a non OK status)

RappyTV commented 8 months ago

hmm weird, some days ago i had a 200 status code but a 400 code in the body, I unfortunately don't have a screenshot. but it's fine because it works now. but what about the lowercase errors? I use the api for a custom uploader and it just does not look pretty when the error messages are not capitalized.

diced commented 8 months ago

i don't really care if it looks pretty or not, its not a priority lol