diced / zipline

A ShareX/file upload server that is easy to use, packed with features, and with an easy setup!
https://zipline.diced.sh/
MIT License
1.31k stars 128 forks source link

Bug: Can't download archives #536

Closed respektive closed 6 months ago

respektive commented 6 months ago

What happened?

Tested on rar, zip and gz files. Works fine on Chromium, but in Firefox I'm getting an error. The logs don't show anything useful. I'm not even seeing the request to the file in them, while I see other requests.

Version

latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)

What browser(s) are you seeing the problem on?

Firefox

Zipline Logs

No response

Browser Logs

No response

Additional Info

No response

diced commented 6 months ago

Not able to reproduce this, I just tried this on a 7z, zip, tar, tar.gz, zip and they all seem to work. The problem might be with the files you are uploading, but I don't have a way of really fixing this since it is most likely a firefox issue.

respektive commented 6 months ago

Turns out i had some malformed nginx config that resulted in the Content-Disposition header being present twice for certain archive files (some weird issues i had with the file upload server i was using before). Chromium apparently just doesn't care about that, but firefox completely blocks the request then, probably some security settings that are on by default. I should have probably checked the nginx config before opening an issue, oops :see_no_evil:

diced commented 6 months ago

Turns out i had some malformed nginx config that resulted in the Content-Disposition header being present twice for certain archive files (some weird issues i had with the file upload server i was using before). Chromium apparently just doesn't care about that, but firefox completely blocks the request then, probably some security settings that are on by default. I should have probably checked the nginx config before opening an issue, oops 🙈

No problem, glad it's fixed though!