diced / zipline

A ShareX/file upload server that is easy to use, packed with features, and with an easy setup!
https://zipline.diced.sh/
MIT License
1.31k stars 128 forks source link

Bug: ShareX profile domain override forces http #566

Closed akitakedits closed 2 months ago

akitakedits commented 2 months ago

What happened?

Using the domain name override during the ShareX profile creation makes final links use http instead of https, even if you define https://somehost.xyz as an override.

I instead simply opted to set the domain name in Domains under Manage User and not define any override in the ShareX profile. But I believe if this is intended, the user should be told overrides won't work with https.

Version

latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)

What browser(s) are you seeing the problem on?

No response

Zipline Logs

No response

Browser Logs

No response

Additional Info

No response

diced commented 2 months ago

probably don't have this option on https://zipline.diced.sh/docs/config/core#core_return_https

sybetjeh commented 1 month ago

probably don't have this option on https://zipline.diced.sh/docs/config/core#core_return_https

i was struggling with this myself too until i found this issue. perhaps document the ssl part better?