dicekeys / beta-program

Information for the DiceKeys beta
5 stars 3 forks source link

"Type your DICEKEY" feature should warn if each letter doesn't appear exactly once. #50

Open yeliaBdE opened 3 years ago

yeliaBdE commented 3 years ago

The user interface for manually typing in a DICEKEY's configuration works well.

However, it allows the entry of patently impossible configurations, and worse, proceeds to generate a password without error.

To replicate:

Enter multiple faces of one or more dice until all 25 spaces are filled; there will be no error when the "Done" button is pressed, nor when a password type is selected, and the password generated. For example, enter "A1" 25 times.

I understand that the intent is to verify the copy using a camera, but a bit of on-the-fly sanity checking (by disallowing the entry of a given letter after it has been previously entered) would allow the user to more quickly identify and correct an error. At the very least, such a check should be done when the "Done" button is pressed.

UppaJung commented 3 years ago

Users can exchange dice, or get multiple sets and pull them out of a shared bag. We consider such uses valid.

However, since the majority of users will have 25 mutually exclusive letters, we can provide a warning of some sort when users have entered a DiceKey for which each letter doesn't appear exactly once, with a stronger warning if only 1-2 letters appear twice and only 1-2 letters are absent. (25 As is presumably on purpose, and if the user draws from two bags of dice we should expect ~7 repeat letters.