search

dicekeys / dicekeys-android

DiceKeys for Android
13 stars 1 forks source link

Rename KeyStoreType in AppkeyStore.kt #163

Closed UppaJung closed 2 years ago

UppaJung commented 2 years ago

https://github.com/dicekeys/dicekeys-android/blob/52998bda6b65d4a93238395bcf2698c5f46bc30e/app/src/main/java/org/dicekeys/app/encryption/AppKeystore.kt#L34

I'd propose the enum class KeystoreType be renamed to enum class KeyStoreCredentialsAllowed and the values to: ALLOW_ONLY_BIOMETRIC_AUTHENTICATION ALLOW_BIOMETRIC_OR_KNOWLEDGE_BASED_AUTHENTICATION ALLOW_ONLY_KNOWLEDGE_BASED_AUTHENTICATION

Also, for consistency, I'd propose replacing all instances of AppKeystore to AppKeyStore unless there's a reason for being inconsistent from the Android casing.

UppaJung commented 2 years ago

Re-opened because enum class KeystoreType not yet renamed to enum class KeyStoreCredentialsAllowed and the values to: ALLOW_ONLY_BIOMETRIC_AUTHENTICATION ALLOW_BIOMETRIC_OR_KNOWLEDGE_BASED_AUTHENTICATION ALLOW_ONLY_KNOWLEDGE_BASED_AUTHENTICATION

Also AppKeystore not yet replaced with AppKeyStore for consistency with Android naming.