dicekeys / dicekeys-android

DiceKeys for Android
11 stars 1 forks source link

Fixes to address/purpose modal #167

Closed UppaJung closed 2 years ago

UppaJung commented 2 years ago

enter-button-hidden

On mobile platforms, perhaps we don't actually edit raw json but instead allow importing of recipes and pasting of json from the clipboard, assuming that those who need specialized recipes will be getting them from somewhere that supports rich editing?

angelix commented 2 years ago

The "close" button is really an "enter" button, so it should be renamed "enter". Maybe "OK" is better?

UppaJung commented 2 years ago

"OK" implies agreement with something. We're not asking them a question. "enter", "done", or "finish" imply "I've completed putting the thing here that I want."

angelix commented 2 years ago

On mobile platforms, perhaps we don't actually edit raw json but instead allow importing of recipes and pasting of json from the clipboard, assuming that those who need specialized recipes will be getting them from somewhere that supports rich editing?

Agree, no need for special json editing. We may lock editing and allow only pasting but it's too strict for my taste.

angelix commented 2 years ago

"OK" implies agreement with something. We're not asking them a question. "enter", "done", or "finish" imply "I've completed putting the thing here that I want."

"Done" is more suitable i think, as user can reopen the bottom sheet to edit the recipe. What do you think?

UppaJung commented 2 years ago

ok. :)

"done" works.