search

dicekeys / dicekeys-android

DiceKeys for Android
13 stars 1 forks source link

Backup/Restore recipes & Migrator #189

Closed angelix closed 2 years ago

angelix commented 2 years ago

Close #134

Add Migrator for migrating data between app versions

Backup structure https://github.com/dicekeys/dicekeys-android/blob/85524f05a18e15e613ad08e21c529bba6e6123c4/app/src/main/java/org/dicekeys/app/data/BackupRecipes.kt

angelix commented 2 years ago

Were you able to test that this works as we think it should work?

Yes, i did some tests, works fine.

Before release i plan to do more tests.

I have a suggestion, rather that having a json storing StoreRecipes[], use a Json Object like the following

{
"version":1,
"recipes": StoreRecipes[]
}

We can add more data in the future if needed, providing backwards compatibility.

UppaJung commented 2 years ago

You mean for the import/export format?

It may already be in use if anyone using dicekeys.app or the electron app has found the feature. So, v0 is that the format is an array and v1 can move to that format. Maybe we should just fail gracefully if the format isn't an array so that when the current version gets a future import format it doesn't cause problems.

UppaJung commented 2 years ago

Read commits up through latest and look good.