UppaJung
commented
2 years ago Looks nice. May not have time to review code today.
On Wed, Jun 8, 2022 at 8:13 AM Angelos Veglektsis @.***> wrote:
- Add sequence number to API response (field name: "#")
- Add a checkbox for whether to send the center letter and digit.
Based on dicekeys/dicekeys-app-typescript#200 https://github.com/dicekeys/dicekeys-app-typescript/pull/200
[image: adb_screenshot] https://user-images.githubusercontent.com/631870/172613219-f2b785dd-d5d2-41e1-9367-a17e239e4f73.png
You can view, comment on, or merge this pull request online at:
https://github.com/dicekeys/dicekeys-android/pull/197 Commit Summary
- 2c5b0dd https://github.com/dicekeys/dicekeys-android/pull/197/commits/2c5b0dd88ab659fceb4c10aa6071bf151d2df9af Add sequence number to API response (field name: "#")
File Changes
(23 files https://github.com/dicekeys/dicekeys-android/pull/197/files)
- M api/build.gradle https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-25d49275b34eb312234a2e92eaef61ca1e0a324f9f534cdf8d5e24b51135c3c6 (2)
- M api/src/main/java/org/dicekeys/api/Api.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-0be7264b5930dbae0565c0e473d1ef777663b806d7ea9877eae3e08ca8e05937 (18)
- M api/src/main/java/org/dicekeys/api/ApiStrings.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-5f01624a27e4bf8db41bbb29fa62f28da45e5bdbbfc32c909cd1816cd8d095f5 (10)
- M api/src/main/java/org/dicekeys/api/DerivationRecipe.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-a26c43496826afbf1bd1720571bb99625c70fbd212247c460f9f6a5331dd04f2 (10)
- M app/build.gradle https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9 (12)
- M app/src/main/java/org/dicekeys/app/RecipeBuilder.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-3a78b4af87622a32916fd921ea12ddf1bac42d81989cfc3b8cc942bbf40472ff (14)
- M app/src/main/java/org/dicekeys/app/apicommands/permissionchecked/PermissionCheckedMarshalledCommands.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-2cb0b7129844a48b42487fd69f6b0f7556dc29abfa57f03a2eccf6f01016cb20 (20)
- M app/src/main/java/org/dicekeys/app/apicommands/permissionchecked/PermissionCheckedUrlCommands.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-09d7db8b5f1dc338680248ce609ff9164e79426829e10cad58102dd716c5070a (17)
- M app/src/main/java/org/dicekeys/app/fragments/ApiRequestFragment.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-c9cea01342559811028081b71199efe8a6d7285c1b5761a57b4e7fce0e3a7744 (88)
- M app/src/main/java/org/dicekeys/app/fragments/dicekey/EditRecipeBottomSheet.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-b9a481914795ce72ca80246d0c7f44e91e6cc628f20e8549db14a01c2ea2ebea (9)
- M app/src/main/java/org/dicekeys/app/viewmodels/ApiRequestViewModel.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-7762c4bfc1ae114b41de0ca78169a6ba5c91a856008ad18466d05514e782d922 (65)
- M app/src/main/java/org/dicekeys/app/viewmodels/RecipeViewModel.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-81bae36648813453bb93095db12bc138ff45f30da1845acfbe1460dee65a538f (18)
- A app/src/main/res/drawable/ic_baseline_remove_24.xml https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-db9f398c2e960dbd3f5a1634b5c5884f37a261ea4cfd1644e53bda028c9fde33 (5)
- M app/src/main/res/layout/api_request_fragment.xml https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-226678ff939d16d38227d5a769f80bb5c8f2ba6c8ae7cc3428e5279d59d5ef62 (78)
- M app/src/main/res/layout/edit_recipe_bottom_sheet_fragment.xml https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-34385c2e8ea3ece7b3043d54a19667ed20fdeedf196ec854f54343b355e30cd9 (42)
- M app/src/main/res/values/strings.xml https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-5e01f7d37a66e4ca03deefc205d8e7008661cdd0284a05aaba1858e6b7bf9103 (3)
- M app/src/main/res/values/styles.xml https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-1e051f2b0330608e92eba8edc616403ec7bdaa76e29ce0cfb794700686715925 (10)
- M app/src/test/java/org/dicekeys/app/RecipeBuilderUnitTests.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-a774868c5af8ad6d93240ee96506a3a40dcac04c8851635db0385380fb24fa64 (20)
- M build.gradle https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7 (2)
- M demo/build.gradle https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-ffd45bd8769a2a67232e79ab904eb2468cd21dbe437c0a950d79ae19a83db68f (10)
- M demo/src/main/java/org/dicekeys/demo/ResponseFragment.kt https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-68c245dd4b419c5638a6d31774a936bb2fd72d2c2dd7836479c955b22950af3d (1)
- M demo/src/main/res/layout/fragment_response.xml https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-ee2b056a6ecce80b49d2e0cbfafa0de5a408151965194741a1076f8edfdfacc8 (12)
- M demo/src/main/res/navigation/nav_graph.xml https://github.com/dicekeys/dicekeys-android/pull/197/files#diff-616507f5290049f98160b493b7d55e890723868156c88c509fe4d9f7e422b7e1 (8)
Patch Links:
- https://github.com/dicekeys/dicekeys-android/pull/197.patch
- https://github.com/dicekeys/dicekeys-android/pull/197.diff
— Reply to this email directly, view it on GitHub https://github.com/dicekeys/dicekeys-android/pull/197, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7AOZYGNEA6CMPI4UPVA6TVOCFABANCNFSM5YGKEAUA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
angelix
Based on https://github.com/dicekeys/dicekeys-app-typescript/pull/200