dickinson-comp190 / GitKit-FarmData2-F23

Other
0 stars 20 forks source link

Tray Seeding Summary displaying NaN values #71

Open MaxiSanc37 opened 10 months ago

MaxiSanc37 commented 10 months ago

When generating a report from the 01/01/2019 to 05/13/2019 the Tray Seeding Summary at the bottom of the page displays NaN values in the "Total Number of Tray Seeds Planted:" and "Average Seeds Planted per Hour:" fields.

How to replicate:

  1. Go into the BarnKit subtab
  2. Generate the seeding report with the start date: 01/01/2019 and the end date: 05/13/2019
  3. Go to the bottom of the page to find the NaN values in the respective fields of the Tray Seeding Summary box

Screenshots:

Screen Shot 2023-10-26 at 3 47 54 AM Screen Shot 2023-10-26 at 3 48 15 AM

We should expect to see the "Total Number of Tray Seeds Planted:" and "Average Seeds Planted per Hour:" fields displaying the correct values instead of NaN.

QuangPhung15 commented 10 months ago

For your ticket issue formatting, I like the way you used bold and italic text to highlight some important information like the date and the tab sections that occurred during the issue. You also pointed out the minimal end date that the issue occurred, so it is easier for others to fix the bug. However, there is something I want to recommend you do is create a section that shows how this issue can be replicated and show what is your expected result.

linhkhanhhoang commented 10 months ago

Your ticket looks nice, especially how you made some of your texts bold and italic. However, some small changes may help this ticket look better. For example, in your "How to replicate" session, it would be nice if you added some initial steps (go to FarmData website, login,...), and also, instead of saying "Screenshots", it's better to say "Observed Output".

longbui23 commented 10 months ago

The ticket looks well-organized and detailed. Great Work!

HoangPhung-11 commented 10 months ago

I like your screenshot, especially how you underline the issue. However, I think you should use "Observed Output" instead of "Screenshot", and make a section called "Expected Output".

evelynpham04 commented 10 months ago

Your ticket covers all the mandatory elements. I would recommend you should have separate sections of Observed Output and Expected Output. Great work!!!