dickinson-comp190 / GitKit-FarmData2-F23

Other
0 stars 20 forks source link

Seeding Report: NaN Values in Tray Seeding Summary #72

Open linhkhanhhoang opened 11 months ago

linhkhanhhoang commented 11 months ago

Description: Sometimes in the Tray Seeding Summary table at the bottom of a Seeding Report, the “Total Number of Tray Seeds Planted” and “Average Seeds Planted per Hour” are reported as NaN (Not a Number) instead of the proper values.

Steps to replicate this problem:

  1. Log into FarmData2 with the correct user credentials
  2. Click on the tab BarnKit and then click on Seeding Report
  3. Set the date range from 10/26/2018 to 10/26/2020 and click Generate Report
  4. Scroll down to the end of the page and see the Tray Seeding Summary session

Observed Output: Screen Shot 2023-10-26 at 11 50 15 AM

Desired Output: Instead of NaN values, the "Total Number of Tray Seeds Planted” and “Average Seeds Planted per Hour” should report some proper values.

HoangPhung-11 commented 11 months ago

Good work!

MaxiSanc37 commented 11 months ago

The issue ticket is very well-detailed and covers all the necessary elements that make a great issue ticket! I would only suggest adding a screenshot of how to set the start and end date, which is not totally necessary but can make it even more descriptive!

QuangPhung15 commented 11 months ago

The ticket shows awesome work because you show a short but detailed description, step-by-step to replicate the issue and add images. However, I would recommend you use bold instead of italic or both because it is easier to skim through what is the important information and what needs to change.

SpencerGoodman commented 11 months ago

The ticket report is very clear, and I like how it included a screenshot. Since the issue is dependent on the date range, having a broad date may make it hard to figure out the exact dates (if any) that are causing the issue. You could provide another date range that it more narrowed down, and show how the error is or isn't occurring. Other than that, I think it was informative.

evelynpham04 commented 11 months ago

Your ticket covers all the mandatory elements. I would recommend the format should be more identical. Great work!