dickinson-comp190 / GitKit-FarmData2-F23

Other
0 stars 20 forks source link

Seeding Report: NaN Values in Tray Seeding Summary Table #73

Open evelynpham04 opened 10 months ago

evelynpham04 commented 10 months ago

In the Tray Seeding Summary table at the bottom of a Seeding Report, the Total Number of Tray Seeds Planted and Average Seeds Planted per Hour fields sometimes display NaN (Not a Number) values instead of the proper values. This behavior appears to be dependent on the date range selected.

Step-by-step directions to reproduce:

Expected output: Regardless of the date range, the Total Number of Tray Seeds Planted and Average Seeds Planted per Hour numbers in the Tray Seeding Summary table should always display accurate numerical values.

Observed output: Image 10-26-23 at 12 25 PM

linhkhanhhoang commented 10 months ago

Hi Evelyn, overall, your ticket looks great but some small changes might make it look better! For example, you want to make the texts that refer to the sessions in the FarmData2 website italic or bold so it's easier to follow. And also, it is better if you point out where the errors are in your observed output screenshot by drawing on it! ^^

SpencerGoodman commented 10 months ago

Very clear and understandable ticket. I enjoyed how it described exactly what the issue seems to be dependent on. The date could possibly be narrowed down, or there could be some other examples of state ranges in which it does not work, in order to find specific dates that cause the issue.

longbui23 commented 10 months ago

Excellent work! You can add some underlines in the picture to specify the issue that you are mentioned like the pic below.

image

MaxiSanc37 commented 10 months ago

The ticket is very clear, has a good description, provides a step-by-step on how to replicate the error, screenshots, and even lets the contributor know the expected and observed outputs. The only thing I would add is annotations in the screenshot so that it's clear where the error is showing.

HoangPhung-11 commented 10 months ago

The issue is valid. I like how you write the description, very detailed and understandable. However, try to use some italics for date and examples to make it easier to follow. Great work!