search

dickinson-comp190 / GitKit-FarmData2-S24

Other
0 stars 17 forks source link

Seeding Report: no logs in table, display a message #56

Open wpgoble opened 8 months ago

wpgoble commented 8 months ago

If there are no logs in the table then the filters, table, and summaries do not show up. The page where they should be is just blank. Instead we want there to be a message saying “There are no logs in the time range you have selected. Please select new dates.”

There are two scenarios when the filters, table, and summaries disappear. First is when there are no logs within the date range, the second is when the user deletes all the logs in the date range. This is likely due to there being no logs in the array seedingLogs.

To test this go to the Seedings Report subtab under BarnKit tab, which is on the home page.

NoLogsNeedMessageIssue

Issue by IrisSC Friday Jul 23, 2021 at 17:56 GMT Originally opened as https://github.com/DickinsonCollege/FarmData2/issues/258

wpgoble commented 8 months ago

Also include Cypress tests that confirm the behavior.

Comment by braughtg Wednesday Sep 01, 2021 at 13:20 GMT

wpgoble commented 8 months ago

I will start work on this

Comment by Batese2001 Thursday Sep 16, 2021 at 21:57 GMT

wpgoble commented 8 months ago

In order for the error message to display appropriately, that is, displaying once the results have been gathered and not while waiting for results to load, issue #272 should be solved first

Comment by Batese2001 Friday Sep 17, 2021 at 19:02 GMT

wpgoble commented 8 months ago

This is also related to #259 and #284. It might be easy to combine them and make a PR that solves both.

Comment by braughtg Tuesday Sep 28, 2021 at 12:13 GMT