Seedings Report: message in Tray/Direct Summaries

dickinson-comp190 / GitKit-FarmData2-S24

Other

0 stars 16 forks source link

Seedings Report: message in Tray/Direct Summaries #57

Open wpgoble opened 10 months ago

wpgoble commented 10 months ago

A user may have all selected for Type of Seeding, but may have selected a crop or area that only has Tray or Direct Seedings. When this happens the other summary will show 0 or NaN (not a number), instead have that summary show a message: “There are no [Tray or Direct] Seedings in the options you have chosen.”

To test this go to the Seedings Report subtab under BarnKit tab, which is on the home page. Selected a date range, and try filtering different Areas and Crops.

An example is shown below: NeedMessageTrayDirectSummaries

This issue is complete when the message appears in Tray and Direct seeding summaries, when there are no current logs in the respective summaries.

Issue by IrisSC Friday Jul 23, 2021 at 18:33 GMT Originally opened as https://github.com/DickinsonCollege/FarmData2/issues/259

wpgoble commented 10 months ago

Also add Cypress tests that confirm this behavior.

Comment by braughtg Wednesday Sep 01, 2021 at 13:19 GMT

wpgoble commented 10 months ago

Instead of a message, if there are only tray seedings or only direct seedings the other summary table should be hidden. If the results contain both tray seedings and direct seedings then both summary tables should be shown.

Comment by braughtg Wednesday Sep 22, 2021 at 12:33 GMT

wpgoble commented 10 months ago

This is related to #284 and #258. A single PR that solves all three would be welcome.

Comment by braughtg Tuesday Sep 28, 2021 at 12:16 GMT

wpgoble commented 10 months ago

Just for clarifications sake, you wanted me to have the summary table with no corresponding logs to show up with a message, so that the user is not confused, correct?

Comment by Batese2001 Wednesday Sep 29, 2021 at 23:10 GMT

wpgoble commented 10 months ago

Just for clarifications sake, you wanted me to have the summary table with no corresponding logs to show up with a message, so that the user is not confused, correct?

I think the desired behavior would be:

If user filters for just tray or just direct seedings then only one table appears.
if user filters for both, and the results contain both then both tables appear.
if user filters for both, and the results contain only direct or only tray (because thats what exists in the date range) then both tables appear, but the one with no records contains a message rather than 0's or NaN's.

If you have other thoughts on what might be better from a usability perspective I'm open to suggestions.

Comment by braughtg Thursday Sep 30, 2021 at 11:56 GMT