search

dickleeza / googlechartseasyphpclass

Automatically exported from code.google.com/p/googlechartseasyphpclass
0 stars 0 forks source link

issues with Chart->Draw() #5

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Hello,

I think the draw function has some flaws:

1) If I want to get the output, I have write: $chart->draw(false). I think
instead of the "$noReturn = true" parameter in the function it should be
"$return = false" so users can get the url by writting: $chart->draw(true).
This would make the function similar to the PHP function
var_export($expression, $return = false)

2) Instead of getting the url through the draw function there should be a
$chart->getUrl() function instead.

3) both The $chart->draw() and $chart->draw(false) return a <br />. At
least the one returning the raw URL shouldn't do that. And the <br /> is
coming from a calculating function which has little to do with drawing the
image (normalDataMode).

Hope this helps.

Original issue reported on code.google.com by minet...@gmail.com on 26 Apr 2010 at 10:37