search

dickmao / nnreddit

A Gnus backend for Reddit
70 stars 5 forks source link

Support fetching by Message-ID? #82

Closed rayes0 closed 2 years ago

rayes0 commented 2 years ago

When trying to get the unfetched parent of the current article or following references to other unfetched articles by, eg, pressing '^' in the summary buffer, it seems nnreddit doesn't support fetching by message-id:

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p "<t1_i5flszg@reddit.com>")
  nnreddit--get-header("<t1_i5flszg@reddit.com>" "emacs")
  nnreddit-request-article("<t1_i5flszg@reddit.com>" "emacs" "" nil)
  gnus-request-article("<t1_i5flszg@reddit.com>" "nnreddit:emacs")
  gnus-request-head("<t1_i5flszg@reddit.com>" "nnreddit:emacs")
  gnus-read-header("<t1_i5flszg@reddit.com>")
  gnus-summary-insert-subject("<t1_i5flszg@reddit.com>")
  gnus-summary-refer-article("<t1_i5flszg@reddit.com>")
  gnus-summary-refer-parent-article(1)
  funcall-interactively(gnus-summary-refer-parent-article 1)
  call-interactively(gnus-summary-refer-parent-article)
  gnus-article-read-summary-keys(nil)
  funcall-interactively(gnus-article-read-summary-keys nil)
  call-interactively(gnus-article-read-summary-keys nil nil)
  command-execute(gnus-article-read-summary-keys)

(with gnus-refer-article-method set to 'current)

Has this just not been implemented yet, is there no way to follow references? Or am I missing something?

dickmao commented 2 years ago

It's one of those things that should be easy, but a bad design makes it hard. 8f247dc at least heads off the Wrong-type-argument error.