dickongwd / pe

0 stars 0 forks source link

Inconsistent naming of roles/materials #7

Open dickongwd opened 11 months ago

dickongwd commented 11 months ago

The user guide examples suggests that we can specify the role as 30 farmer and the material as 30 potatoes.

image.png

I understand that 30 potatoes is okay since when we add materials, we use the maddv command with the m/ flag to specify m/x potatoes. But the role is singular which is a bit inconsistent with the rest of the app.

nus-se-bot commented 11 months ago

Team's Response

Whether the material name is singular or plural depends on how the user types in the material using the ecreate or eedit command. As long as the eaddm command follows the material name with the same singular/plural form, this would not be an issue but definitely could be improved on in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]