dickwolff / Export-To-Ghostfolio

Convert transaction history export from your favorite broker to a format that can be imported in Ghostfolio.
https://hub.docker.com/r/dickwolff/export-to-ghostfolio
Apache License 2.0
63 stars 10 forks source link

Only Fees being processed in Docker #52

Closed mikaelheidrich closed 7 months ago

mikaelheidrich commented 7 months ago

Hi Dick,

I'm back after a long time! great work on the converter in the mean time! Congrats.

I've been playing with the docker instance. Using both docker and docker compose. When trying to process Finpension and Swissquote, the only data converted is fees and interest but no equities.

let me know what you may need to track this down. Mikael

dickwolff commented 7 months ago

Hi @mikaelheidrich! Thanks for creating this issue. As there have been no changes to either converter, it would be weird for them not to work (also because the unit tests do succeed as far as I’m aware). Could you perhaps provide a (partial) export so I could try it myself? Thanks!

mikaelheidrich commented 7 months ago

Hi Dick,

Yeah, I found it weird too. same behaviour both executing from docker and docker-compose. here is the finpension csv I was trying to convert. transaktions_report.csv

thanks!

dickwolff commented 7 months ago

Thanks. Will look into it later this weekend.

To verify, the Docker logs do state the Finpension converter is being used?

mikaelheidrich commented 7 months ago

Yes, now and again it gets identified as Rabobank and then ultimately it runs as finpension.

dickwolff commented 7 months ago

Thanks! Will check tomorrow if I can find a solution!

dickwolff commented 7 months ago

@mikaelheidrich I took the transaktions_report.csv file and ran npm run start finpension. It gave me the following result: ghostfolio-finpension.json. At first glance it does look allright.

I did however see a lot of errors retrieving symbols from Yahoo Finance. After running npm install those went away. There was a new version of the Yahoo Finance library available which I had not installed locally. Could you maybe try if this resolves the issue when running locally? If that works for you, probably upgrading the Docker image to 0.8.2 will resolve it as well.

Regarding the Rabobank converter matching; that's weird. The headers of both files differ a lot, so currently I have no clue why the watcher thinks it to be a Rabobank file.

mikaelheidrich commented 7 months ago

Hi Dick, I pulled the new docker image and re-ran the transactions_repot.csv and it seems to work now.

A thought. with the docker image its possible to have the container persist and watch the 'input' folder. that would give the possibility of batch processing, trouble is that the process then writes out the the output folder but overwrites files already processed. Is it possible to have the process simply write a new file name for each file processed. for example. ghostfolio-pension.json, and then if it already exists ghostfolio-pension-2.json etc.. or maybe even include the date.

dickwolff commented 7 months ago

Thanks for your suggestion. I will add the current timestamp to the filename!

dickwolff commented 7 months ago

Now available in 0.8.3.

dickwolff commented 7 months ago

Closing since original issue is solved.

Should you have any other request or issues, please open a new issue!