search

dickwolff / Export-To-Ghostfolio

Convert transaction history export from your favorite broker to a format that can be imported in Ghostfolio.
https://hub.docker.com/r/dickwolff/export-to-ghostfolio
Apache License 2.0
63 stars 10 forks source link

Swissquote and finpension as brokers #7

Closed mikaelheidrich closed 11 months ago

mikaelheidrich commented 1 year ago

Any chance of adding Swissquote and finpension as importable brokerages?

dickwolff commented 1 year ago

If you can provide me with example exports I can take a look at it!

mikaelheidrich commented 1 year ago

Hey thanks for the quick response. attached are an example of finpension transaction exported csv and another from swissquote.

thanks!! swissquote_transactions.csv transaction_report_finpension.csv

On 27 Oct 2023, at 07:56, Dick Wolff @.***> wrote:

If you can provide me with example exports I can take a look at it!

— Reply to this email directly, view it on GitHub https://github.com/dickwolff/Export-To-Ghostfolio/issues/7#issuecomment-1782340163, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVZSRSWCWWGUBTLFZESPQDLYBNEHFAVCNFSM6AAAAAA6SIYZTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGM2DAMJWGM. You are receiving this because you authored the thread.

mikaelheidrich commented 1 year ago

Are these CSVs ok or do you need more examples?

dickwolff commented 1 year ago

Sorry, haven't had time to look at it yet. After a quick glance just now I think the finpension export will work, but I need more transactions for Swissquote (different kinds, for example buy/sell are missing).

mikaelheidrich commented 1 year ago

Ok, I’ll upload a more elaborate csv later today. No worries. Appreciate you taking the time to check it out! :)

mikaelheidrich commented 1 year ago

Heya, heres a more elaborate swissquote example. swissquote_transaction-2.csv

dickwolff commented 1 year ago

This could work. When I have some time I will try and work this out!

dickwolff commented 1 year ago

I have added a Finpension converter here. Can you try and verify if it works for you? The file you provided is converted succesfully and as far as I can see all looks good.

Please let me know if you have any findings. If all is good, can you provide me with step-by-step instructions how to make a Finpension export (like here), so I can add it to the readme?

When I find some time later this week I will work on the Swissquote converter!

dickwolff commented 1 year ago

@mikaelheidrich I also added the Swissquote converter to the same branch.

Can you take a look at them and verify if they process your exports? Both CSV's you provided seem to be converted OK and are importable to Ghostfolio.

Can you also provide export instructions for Swissquote (as well as for Finpension), so I can add those to the manual? Thanks!

mikaelheidrich commented 1 year ago

Hi Dick,I had a quick look at finpension, looks good at first glance. I take a look at the Swissquote over the weekend and will provide instructions on how to download the csv for both. Thanks a lot!MikaelOn 24 Nov 2023, at 09:59, Dick Wolff @.***> wrote: @mikaelheidrich I also added the Swissquote converter to the same branch. Can you take a look at them and verify if they process your exports? Both CSV's you provided seem to be converted OK and are importable to Ghostfolio. Can you also provide export instructions for Swissquote (as well as for Finpension), so I can add those to the manual? Thanks!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

mikaelheidrich commented 1 year ago

Hi Dick,

tinkering with swissquote and have the following errors and crash when importing the balance of my last three year's transactions. Screen shot from the terminal.

image

US8863645383 is an ETF that has been discontinued

Thanks,

Mikael

On 24 Nov 2023, at 09:59, Dick Wolff @.***> wrote:

@mikaelheidrich https://github.com/mikaelheidrich I also added the Swissquote converter to the same branch.

Can you take a look at them and verify if they process your exports? Both CSV's you provided seem to be converted OK and are importable to Ghostfolio.

Can you also provide export instructions for Swissquote (as well as for Finpension), so I can add those to the manual? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/dickwolff/Export-To-Ghostfolio/issues/7#issuecomment-1825343266, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVZSRSVNKQYIWMTE3XRWEYLYGBOYNAVCNFSM6AAAAAA6SIYZTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVGM2DGMRWGY. You are receiving this because you were mentioned.

dickwolff commented 1 year ago

I had this same error on Yahoo Finance this morning, I believe this is because Yahoo Finance is rate limiting you because their api was requested too many times within the hour.

As for the discontinued ETF, it isn’t placed in the JSON which you import in Ghostfolio?

mikaelheidrich commented 1 year ago

No the discontinued ETF does not appear in the json file after being processed. I have retried the swissquote csv’s with less entries 20 instead of 79. but no matter the amount of requests same error pops up. I can run 5 different Finpension accounts all with 100 plus activities without error. Seems something specific to the swissquote process.

thanks again for the help.

Mikael

ill try and get some instructions and screen shots for how to download the transaction csv’s in the coming days.

dickwolff commented 1 year ago

Okay, I will try and look into the Swissquote error later this week and get back to you when I find something!

mikaelheidrich commented 1 year ago

Hi Dick,

For Finpension. Login to your Finpension account. Select your portfolio from the landing page. Then to the right of the screen select “Transactions”, on the following page to the right notice “transaction report (CSV-file)” and click to email or click to download locally.

For Swissquote Switzerland. Login to the Swissquote account. From the bar menu click on “Transactions”. Select the desired time period as well as types and then select the “export CSV” button to the right.

hope this helps.

Thanks Dick, looking forward to getting Swissquote working 100%!

Mikael

On 26 Nov 2023, at 17:43, Dick Wolff @.***> wrote:

I had this same error on Yahoo Finance this morning, I believe this is because Yahoo Finance is rate limiting you because their api was requested too many times within the hour.

As for the discontinued ETF, it isn’t placed in the JSON which you import in Ghostfolio?

— Reply to this email directly, view it on GitHub https://github.com/dickwolff/Export-To-Ghostfolio/issues/7#issuecomment-1826831888, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVZSRSVQSK4JE66BXBDML4DYGNWTRAVCNFSM6AAAAAA6SIYZTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWHAZTCOBYHA. You are receiving this because you were mentioned.

dickwolff commented 1 year ago

Thanks for the instructions! I have added them to the readme file.

As to the issue you describe with Swissquote. I have run the export you provided in this thread (swissquote_transaction-2.csv) without any issue just now. Can you please check wether you still have issues at this time? If so, can you provide me with a (partial) export of the record(s) that give you an error? That way I can analyse the issue and get to a fix.

mikaelheidrich commented 12 months ago

Hi Dick,

I have attached a csv with the transactions that crash the converter. It looks like it's the forex debit ones that generate the error. In the screen shot also see the no result found notices. how do I fix those ones?

thank for the help. Going to be a slick little app… Mikael

On 1 Dec 2023, at 10:44, Dick Wolff @.***> wrote:

Thanks for the instructions! I have added them to the readme file.

As to the issue you describe with Swissquote. I have run the export you provided in this thread (swissquote_transaction-2.csv) without any issue just now. Can you please check wether you still have issues at this time? If so, can you provide me with a (partial) export of the record(s) that give you an error? That way I can analyse the issue and get to a fix.

— Reply to this email directly, view it on GitHub https://github.com/dickwolff/Export-To-Ghostfolio/issues/7#issuecomment-1835781579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVZSRSQWLZUDTO4ZPFAFVQDYHGRG5AVCNFSM6AAAAAA6SIYZTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVG44DCNJXHE. You are receiving this because you were mentioned.

dickwolff commented 12 months ago

I don't see an attachment. Don't think that works when replying via email. Can you add them in this issue on GitHub?

mikaelheidrich commented 12 months ago

oops sorry here you go. failed_transactions-swissquote.csv Screenshot 2023-12-04 at 09 51 11

dickwolff commented 11 months ago

They were records without an ISIN, so no wonder they break 😁

I have added them to the skip list. Can you verify one last time before I merge these changes?

mikaelheidrich commented 11 months ago

Hi Dick, exporter runs now with no crashing. So I have gone through three years of transactions and I have merged all the remainng troublesome exports from my broker into one csv.

sample-swissquote-export.csv

The following is noteworthy.

-VEUD Dividend is mis identified as veurl.as where as the VEUD buy or sell is correctly identified as VEUD.L -Custody Fees should be identified as Fees -ORFN is the discontinued ETF, I can enter those manually i think

I could also be noted that, after deselecting wrong imports in Ghostfolio and subsequently deleting succesful transactions from the cvs and then re-runing the export tool, some of the faulty exports where then exported correctly. That is to say, trimming down the csv and reruning it sometimes fixed some of the faulty exports.

hope this helps,

Mikael

dickwolff commented 11 months ago

Thanks for your detailed analysis. I will try to take a look this weekend and come back to you.

dickwolff commented 11 months ago

@mikaelheidrich The file you attached seems to be empty

mikaelheidrich commented 11 months ago

strange, lets try this one:

sample-swissquote-export-merged.csv

dickwolff commented 11 months ago

I added custody fee support. Will now look at the file you sent and check your analysis.

dickwolff commented 11 months ago

@mikaelheidrich Did you manaually merge the files? The tool does not process is because the column count does not match. The header has 15 columns, but there are many rows with only 13 columns.

For now I have removed the 13 colums rows and then I can process the file. Will try again with 13 columns with changed header.

dickwolff commented 11 months ago

Pushed some more changes.

Regarding your analysis, my thoughts below:

dickwolff commented 11 months ago

Merged changes into main branch. If any issues persist, please open a new issue.

mikaelheidrich commented 11 months ago

Heya Dick,Sorry to not have responded. Holidays busy busy around here. I’ll take a look at things after the new year and touch base. Thanks a bunch!Happy holiday abs happy new year.On 28 Dec 2023, at 11:32, Dick Wolff @.***> wrote: Closed #7 as completed via #10.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>