search

dicom / ruby-dicom

Library for reading, editing and writing DICOM files, as well as handling DICOM network communication. Written in the Ruby language.
http://dicom.rubyforge.org/
GNU General Public License v3.0
178 stars 68 forks source link

Switching from JSON to YAML due to issues with german umlauts #36

Closed smiley-269 closed 12 years ago

smiley-269 commented 12 years ago

As discussed by mail I packed the mentioned changes into this pull request.

One major point could be that the resulting audit file will no longer be plain ASCII. Instead the value pairs of strings will be encoded in a non-human readable binary format.

regards Andreas

dicom commented 12 years ago

Thank you for this contribution, Andreas.

Actually I kind of like the fact the Audit file is easily readable. However, I'm thinking perhaps we should make this configurable. Sort of like how you can choose an image processor (rmagick or mini_magick) in ruby-dicom, perhaps we could provide a choice between json and yaml for the audit file as well (with json being default)?

What do you think?

smiley-269 commented 12 years ago

Having it switchable would be perfectly fine with me.

dicom commented 12 years ago

This error should be fixed by the following commit: https://github.com/dicom/ruby-dicom/commit/56355b272a5b5774f5fe20d8e691da9cf8e79b23

I have been working to make ruby-dicom properly handle encoding, and a side effect of this effort is that the anonymizer's audit trail no longer crashes on those non ascii string. Please check it out. Hopefully this should negate the need for yaml dump. However if you still want that feature, consider opening a separate issue.

smiley-269 commented 12 years ago

Hi Christopher,

Using YAML was just a way to make it work quickly. If ruby-dicom now works in the given scenario without it, it is perfectly fine with me. I will try it out some time during the next weeks and let you know the result.

Regards Andreas

On Thu, Jul 26, 2012 at 4:14 PM, Christoffer Lervåg < reply@reply.github.com

wrote:

This error should be fixed by the following commit:

https://github.com/dicom/ruby-dicom/commit/56355b272a5b5774f5fe20d8e691da9cf8e79b23

I have been working to make ruby-dicom properly handle encoding, and a side effect of this effort is that the anonymizer's audit trail no longer crashes on those non ascii string. Please check it out. Hopefully this should negate the need for yaml dump. However if you still want that feature, consider opening a separate issue.

Reply to this email directly or view it on GitHub: https://github.com/dicom/ruby-dicom/pull/36#issuecomment-7278694