MarkRx commented 3 years ago

Add optional "long" specifier to numb command

Adds ability to prefix 'numb' command with 'long' to surround with spaces.

Description

Prefixing the numb command with "long" surrounds the resulting numbers with spaces. This makes it easier to interweave numbers into command chains and dictations. Additionally saying "ace" can be problematic because sometimes it is misinterpreted as an "a" instead of a space.

Example: Before: Cop there are ace numb seven ace laws days in a week bam Output:

There are 7 days in a week.

After: Cop there are long numb seven laws days in a week Output:

There are 7 days in a week.

Motivation and Context

Makes dictation with interleaved numbers easier

How Has This Been Tested

I dictated the "numb" command with and without "long"

Types of changes

[x] Docs change / refactoring / dependency upgrade
[x] New feature (non-breaking change which adds functionality)

Checklist

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] I have checked that my code does not duplicate functionality elsewhere in Caster.
[x] I have checked for and utilized existing command phrases from within Caster (delete if not applicable).
[x] My code implements all the features I wish to merge in this pull request.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests pass.

Maintainer/Reviewer Checklist

[x] Basic functionality has been tested and works as claimed.
[x] New documentation is clear and complete.
[x] Code is clear and readable.

kendonB commented 3 years ago

@MarkRx an excellent contribution! It looks fine to me. I will test it properly once I'm at my computer. We're usually hesitant to add new phrases to the core but in this case I think it actually reduces the likelihood of misrecognition.