dictation-toolbox / Caster

Dragonfly-Based Voice Programming and Accessibility Toolkit
https://dictation-toolbox.github.io/Caster/
Other
340 stars 121 forks source link

keyboard grammar does not hold a series of modifier keys #877

Closed LexiconCode closed 3 years ago

LexiconCode commented 3 years ago

Issuehunt badges

Describe the bug Keyboard command with the hold/release modifier for a series keypresses is not recognized is not a valid command. The modifier key combos are not included in the button_dictionary_1. Some thought will have to begin how to include them whether it's in button_dictionary_1or something else.

To Reproduce Steps to reproduce the behavior (be sure to include the exact command phrase you are using): Test case 1

  1. Start the test engine
  2. Say 'hold control shift'
  3. command not recognized

Test case 2

  1. Say 'control shift'
  2. command recognized

Expected behavior hold modifiers should work as expected

There are issues modifying command as the following:

        "<hold_release> (<modifier> | <button_dictionary_1>)":
              R(Key("%(modifier)s | %(button_dictionary_1)s:%(hold_release)s"),
              rdescript="%(hold_release)s button: %(button_dictionary_1)s"),             

IssueHunt Summary #### [lexiconcode lexiconcode](https://issuehunt.io/u/lexiconcode) has been rewarded. ### Backers (Total: $100.00) - [itsrainingschmen itsrainingschmen](https://issuehunt.io/u/itsrainingschmen) ($100.00) ### Submitted pull Requests - [#879 Commands for hold multiple modifier keys one utterance](https://issuehunt.io/r/dictation-toolbox/Caster/pull/879) --- ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/dictation-toolbox/Caster/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.
issuehunt-oss[bot] commented 3 years ago

@itsrainingschmen has funded $100.00 to this issue.


issuehunt-oss[bot] commented 3 years ago

@lexiconcode has rewarded $90.00 to @lexiconcode. See it on IssueHunt