dictation-toolbox / Caster

Dragonfly-Based Voice Programming and Accessibility Toolkit
Other
337 stars 122 forks source link

Remove IntegerRefST #878

Closed LexiconCode closed 3 years ago

LexiconCode commented 3 years ago

Description

Remove integer_remap_crash_fix and integer_remap ShortIntegerRef as IntegerRefST compatibility shim

Related Issue

https://github.com/dictation-toolbox/Caster/issues/857 Unable to dictate 5 consecutive numbers IntegerRefST has caused issues with again do command

Motivation and Context

IntegerRefST was originally used for integer_remap_crash_fix and integer_remap integer_remap allowed you to remap some integers names to your own preference. However this feature has not been used my knowledge by anyone since my time utilizing caster over 6 years. It's caused a number of bugs both with numerics and again do grammar hence its removal.

How Has This Been Tested

A compatibility variable was left within from castervoice.lib.merge.additions renaming ShortIntegerRef as IntegerRefST. This allows end-user grammars that may be relying on IntegerRefST to have compatibility with ShortIntegerRef without breaking their grammar.

if ShortIntegerRef is imported than a warning message will appear to the end-user to migrate their imports.

Types of changes

Checklist

Maintainer/Reviewer Checklist