dictation-toolbox / Caster

Dragonfly-Based Voice Programming and Accessibility Toolkit
https://dictation-toolbox.github.io/Caster/
Other
340 stars 121 forks source link

Prevent multiple navigation overlays from stacking #893

Closed BenChand closed 3 years ago

BenChand commented 3 years ago

Title

Prevent multiple navigation overlays from stacking

Description

Currently it's possible to trigger multiple navigation modes at once, causing grids like rainbow and sudoku to overlap with one another. This becomes confusing because it's not obvious what order is needed to exit these grids.

This change also check to see if any other navigation mode has been started, and if so, raises an exception so that the new navigation mode doesn't wait around for its window to appear.

Related Issue

Motivation and Context

I keep triggering multiple ones by accident and wanted to fix it.

How Has This Been Tested

Manual testing, tracking that new navigation modes can not be triggered if one is currently on the screen

Types of changes

Checklist

Maintainer/Reviewer Checklist

BenChand commented 3 years ago

Not sure why the python2 build is failing, can't see it being related to the changes

LexiconCode commented 3 years ago

You are correct it's not related to your code. Are you on the latest master? That should be fixed. The Microsoft c++ compilers are no longer available for Python 2.7. Therefore a package can't compile. It was resolved by including a pre-compiled package for regex.

Fortunately when we drop Python 2 support this will no longer be an issue.

BenChand commented 3 years ago

Yeah this is using the latest on master I believe

LexiconCode commented 3 years ago

The compiling issue issue will be fixed in the next release of dragonfly.