kendonB commented 3 years ago

Get github automation working on ubuntu

Description

A few tweaks to get the automatic checkout pull request feature to work on linux. I think this should also work on Mac.

Related Issue

None.

Motivation and Context

As above.

How Has This Been Tested

This has only been tested on ubuntu.

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue or bug)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Renamed existing command phrases (we discourage this without a strong rationale).

Checklist

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] I have checked that my code does not duplicate functionality elsewhere in Caster.
[x] My code implements all the features I wish to merge in this pull request.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[x] All new and existing tests pass.

Maintainer/Reviewer Checklist

[ ] Basic functionality has been tested and works as claimed.
[ ] New documentation is clear and complete.
[ ] Code is clear and readable.

LexiconCode commented 3 years ago

Depending on your time as I know you're busy. A way to improve the code with to be breaking it up into more functions and/or a class. This makes it that only the see the different components and their purpose that makes it easier to test as well.

I'll see if I can get around testing this soon!

kendonB commented 3 years ago

Depending on your time as I know you're busy. A way to improve the code with to be breaking it up into more functions and/or a class. This makes it that only the see the different components and their purpose that makes it easier to test as well.

I'll see if I can get around testing this soon!

I don't think I have the time to do a good job of tidying this up just yet. Should I open an issue?

LexiconCode commented 3 years ago

Depending on your time as I know you're busy. A way to improve the code with to be breaking it up into more functions and/or a class. This makes it that only the see the different components and their purpose that makes it easier to test as well.

I'll see if I can get around testing this soon!

I don't think I have the time to do a good job of tidying this up just yet. Should I open an issue?

Sure

LexiconCode commented 3 years ago

I still need iron out a few things with Path. You can hold off for a bit on the review comments yet.

LexiconCode commented 3 years ago

@kendonB

This is unrelated to this PR so keep that in mind. I can't get this to work as it keeps failing despite pulling up MINGW64.

print("Error:" + ahk_script + " neither returned 'activated' nor 'does not exist'")
print("Fallback: load new instance of :" + pattern_match)

I will keep looking into it. I think I can re-implement this work doesn't have to rely on AutoHotkey making it cross-platform using dragonfly. If my understanding is correct github_automation.ahk checks to see if a window title exists or waits for the title to become available. What do you think?

kendonB commented 2 years ago

@LexiconCode Yes it would be good if we didn't have to rely on AHK. I think we needed that earlier before dragonfly had that functionality

dictation-toolbox / Caster