dictation-toolbox / Caster

Dragonfly-Based Voice Programming and Accessibility Toolkit

Other

336 stars 122 forks source link

Update reload_fn_provider.py #947

Closed Kentoseth closed 1 week ago

Kentoseth commented 3 weeks ago

A python 3.12 bug I encountered.

Description

imp was dropped in 3.12 but supported in most 3.x versions

Related Issue

Motivation and Context

Caster won't work in 3.12 without this change.

How Has This Been Tested

I added the code and Caster worked after that.

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[X] Bug fix (non-breaking change which fixes an issue or bug)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Renamed existing command phrases (we discourage this without a strong rationale).

Checklist

[ ] I have read the CONTRIBUTING document.
[X] My code follows the code style of this project.
[X] I have checked that my code does not duplicate functionality elsewhere in Caster.
[X] My code implements all the features I wish to merge in this pull request.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests pass.

Maintainer/Reviewer Checklist

[x] Basic functionality has been tested and works as claimed.
[x] New documentation is clear and complete.
[x] Code is clear and readable.

LexiconCode commented 1 week ago

Thank You!

Deprecated since version 3.4, will be removed in version 3.12