dictation-toolbox / aenea

Client-server library for using voice macros from Dragon NaturallySpeaking and Dragonfly on remote/non-windows hosts.
GNU Lesser General Public License v3.0
211 stars 62 forks source link

Improved os x server (various things) #162

Closed dylan-chong closed 6 years ago

dylan-chong commented 6 years ago

I've been using @seananderson 's set up for over a year now and it's been working amazingly! I completely forgot that I had done so, so I thought I'd better submit these changes. @seananderson I hope you don't mind me stealing some of your commits!

Fixes:

calmofthestorm commented 6 years ago

I haven't forgotten about this. I'll try to take a look soon.

seananderson commented 6 years ago

Thanks for putting together the pull request, @dylan-chong! I'm glad you found the changes useful and I'm thrilled to have someone else to debug this with as macOS evolves. I'm pretty dependent on it for my work.

calmofthestorm commented 6 years ago

I looked over the diff and I don't have any comments; these all look like reasonable changes. As I noted above, I unfortunately don't have any way to actually test this on OS X, but LGTM.

Should I go ahead and merge this?

dylan-chong commented 6 years ago

Not just yet. I want to investigate the comments from sean anderson before merging

dylan-chong commented 6 years ago

@calmofthestorm Ready for merge now. I have just pushed one more commit in case you want to check it

calmofthestorm commented 6 years ago

Thank you both for your efforts on this change.