Closed dylan-chong closed 6 years ago
I haven't forgotten about this. I'll try to take a look soon.
Thanks for putting together the pull request, @dylan-chong! I'm glad you found the changes useful and I'm thrilled to have someone else to debug this with as macOS evolves. I'm pretty dependent on it for my work.
I looked over the diff and I don't have any comments; these all look like reasonable changes. As I noted above, I unfortunately don't have any way to actually test this on OS X, but LGTM.
Should I go ahead and merge this?
Not just yet. I want to investigate the comments from sean anderson before merging
@calmofthestorm Ready for merge now. I have just pushed one more commit in case you want to check it
Thank you both for your efforts on this change.
I've been using @seananderson 's set up for over a year now and it's been working amazingly! I completely forgot that I had done so, so I thought I'd better submit these changes. @seananderson I hope you don't mind me stealing some of your commits!
Fixes: