search

dictation-toolbox / aenea

Client-server library for using voice macros from Dragon NaturallySpeaking and Dragonfly on remote/non-windows hosts.
GNU Lesser General Public License v3.0
211 stars 62 forks source link

Remove imports for Dragonfly's sendinput structs #205

Closed drmfinlay closed 5 years ago

drmfinlay commented 5 years ago

This PR removes the import statements for Dragonfly's sendinput structs: HardwareInput, KeyboardInput and MouseInput. Importing dragonfly should work on other platforms if these are removed, meaning that Aenea's client code can work on Linux without mocking.

@calmofthestorm If you think it's worth it, I can re-mock these structs for other platforms in dragonfly, but AFAIK they're only used internally by the Keyboard class.

calmofthestorm commented 5 years ago

Probably not worth the effort to re-mock, but it's up to you. We don't exactly have robust test coverage in Aenea, so as long as what we do have keeps working I don't think we should spend much time on mocks.

Thanks for the cleanup!

The CI failure is due to the lint errors from the other PR.

drmfinlay commented 5 years ago

No worries. Yep, I agree. I'll leave Dragonfly's sendinput structs and functions unavailable on other platforms.

BTW I have tested that Aenea's client code running on my Linux machine can be used to control my mac over the network :-)