Closed LexiconCode closed 1 year ago
looked at code, checked with author about dragonversion=15 — that is as intended.
looked at code, checked with author about dragonversion=15 — that is as intended.
Yes it is and that is confusing. Why is a confusing?
The installer makes decisions about which compiled .pyd is utilized. This is determined by version numbers.
this is unfortunate because _natlink_core15.pyd actually supports DPI v14/v15/v16 not just DPI v15. _natlink_core13.pyd
support only DNS v13 and possibly DNS v12.
The variable dragonversion
should actually represent the installed dragon version and there should be logic elsewhere to handle if it's equal or greater than or less than version DPI 14
looked at code, checked with author about dragonversion=15 — that is as intended.
@dougransom
The BestGuessDragonIniDir
updates the global variable dragonversion
global variable dragonversion
is returned in the following function GetDragonVersion
GetDragonVersion
is used when registering .pyd which must be v13 or v15 as those are the only two filenames that exist. See _natlink_core{code:GetDragonVersion}.pyd
below
The adds initial support for DPI v16. This simply adds the required path for
inno-code.iss
Todo:
Other thoughts However I think how we handle version numbers within
inno-code.iss
could improved.DragonVersion := '15';
actually handles DragonVersion 14/15/16 this should be reflected better within the code without relying on absolute version numbers.