dictation-toolbox / natlink

Natlink provides the interface between Dragon and python
Other
25 stars 17 forks source link

Remove InstallTest #88

Closed LexiconCode closed 2 years ago

LexiconCode commented 2 years ago

@quintijn This pr removes InstallTest form the natlink code base.

As we are making progress to a release this code should be removed as its has served its porpoise in early development.

I can update natlinkv5.0.0.pre if needed.

Configuring natlink.ini needs to be in the docs. However a basic natlink.ini should be generated by the installer during install time.

ToDo

quintijn commented 2 years ago

OK LexiconCode, go ahead. On second thought, we need to discuss this, see Telegram...

About the location of natlink.ini: I was working on something before, but it got rejected by fusenthasticus, because he found it too complicated.

The HOME directory should be IMHO in C:\Users\xxxx and not pointing to the underlying Documents directory.

The .natlink directory comes in this HOME directory when you do not configure anything. Bad luck about backups. The .natlink config file is restored quick enough after a loss. Rename to natlink.ini is a good idea.

I again propose to support an env variable DICTATIONTOOLBOXHOME which a user can set to the Documents folder or a choosen folder in the documents folder:

DICTATIONTOOLBOXHOME = C:\Users\XXX\Documents or

DICTATIONTOOLBOXHOME = C:\Users\XXX\Documents\DTHOME

It should be created at start of configure time.

I will in each case change ".natlink" into "natlink.ini"

Please react on my other proposal... Greetings, Quintijn

dougransom commented 2 years ago

"The HOME directory should be IMHO in C:\Users\xxxx and not pointing to the underlying Documents directory."

Yes, makes sense. Config files don't go in Documents.

"I again propose to support an env variable DICTATIONTOOLBOXHOME which a user can set to the Documents folder or a choosen folder in the documents folder:"

Yes, especially for testing multiple installs, or for specific places on cloud drives. If environment variable doesn't exists (and probably shouldn't by default) then it defaults to the home folder.

.toml seems to be the new .ini.

From: Quintijn Hoogenboom @.> Sent: Sunday, February 13, 2022 3:05 AM To: dictation-toolbox/natlink @.> Cc: Subscribed @.***> Subject: Re: [dictation-toolbox/natlink] Remove InstallTest (PR #88)

OK LexiconCode, go ahead.

About the location of natlink.ini: I was working on something before, but it got rejected by fusenthasticus, because he found it too complicated.

The HOME directory should be IMHO in C:\Users\xxxx and not pointing to the underlying Documents directory.

The .natlink directory comes in this HOME directory when you do not configure anything. Bad luck about backups. The .natlink config file is restored quick enough after a loss. Rename to natlink.ini is a good idea.

I again propose to support an env variable DICTATIONTOOLBOXHOME which a user can set to the Documents folder or a choosen folder in the documents folder:

DICTATIONTOOLBOXHOME = C:\Users\XXX\Documents or

DICTATIONTOOLBOXHOME = C:\Users\XXX\Documents\DTHOME

It should be created at start of configure time.

I will in each case change ".natlink" into "natlink.ini"

Please react on my other proposal... Greetings, Quintijn

- Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdictation-toolbox%2Fnatlink%2Fpull%2F88%23issuecomment-1038019719&data=04%7C01%7C%7Cc10ef2e2195c41d450cc08d9eee0b4a6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803471132940389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Rhr9SyAO3skNQd%2FLY9G9nw6EM3lRlvTlmNzDwF9AnRk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA262UTWNSB4YCSATCGJFCTU26F6HANCNFSM5OGLAVCA&data=04%7C01%7C%7Cc10ef2e2195c41d450cc08d9eee0b4a6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803471132940389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=LEx1Yzh4q3CMPTRqFxhewdNb6%2FKm%2FAkuhuYmq5DFt78%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cc10ef2e2195c41d450cc08d9eee0b4a6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803471133096604%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hn3k4Q6hIc1SA9G%2FkhP73Mi6%2BlN3TlYZrs4t6Cr%2BiaQ%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Cc10ef2e2195c41d450cc08d9eee0b4a6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637803471133096604%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Knnfr3ovuHwFtssb1Q0V4mfOKj6YQnTfTB%2FuzAeqM78%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

LexiconCode commented 2 years ago

quintijn has asked me to close this PR.