dictationbridge / dictationbridge-nvda

DictationBridge NVDA add-on
GNU General Public License v2.0
10 stars 5 forks source link

When updating from one version of db to the next, db will remove the old path from the system, as if it were being removed #16

Closed derekriemer closed 6 years ago

derekriemer commented 7 years ago
  1. Install a new version of db on top of an old version.
  2. Now, check your path.

expected: Db is in the path:

Actual: it's not.

Technical: DB adds its addon directory to the users path on install. However, the previous NVDA addon version runs onUninstall right after NVDA reboots. This then triggers the addon to remove itself from the path.

To fix this, we should force all dll's into a version specific directory, for the addons version. we need to then add %appdata%\nvda\addons\dictationBridge\ or something to the path. This will allow the previous version to remove the old path, and will also create isolation of our dll's to avoid situations like https://github.com/nvaccess/nvda/issues/7563.

derekriemer commented 7 years ago

@mwcampbell can you think of any situations where using version specific directories for our DLL's will cause problems?

derekriemer commented 6 years ago

fixed.