dictationbridge / dictationbridge-nvda

DictationBridge NVDA add-on
GNU General Public License v2.0
10 stars 5 forks source link

Refactor: allow Dictationbridge to copy custom commands to a dictation software of user's choosing, not just limited to Dragon #5

Closed josephsl closed 7 years ago

josephsl commented 7 years ago

Hi,

Part of a refactoring work:

one of the assumptions in DictationBridge is that only Dragon can include custom commands. It turns out one can define custom macros for Windows Speech Recognition (WSR; see issue #4) and one must copy the custom macro file to a special folder.

Thus I propose rewriting the dictation command copy routine as follows:

  1. Rename "Install Dragon Commands" to "Install custom dictation commands".
  2. Locate dictation software (WSR and/or Dragon).
  3. In case of Dragon, let users select version in use (issue #3).
  4. Copy custom commands (see issues #3 and #4 for details).

Thanks.

derekriemer commented 7 years ago

The problem is the user might only want to install one engines commands. @josephsl Are you happy with the current addons submenu approach?

josephsl commented 7 years ago

Hi, yes. Be mindful that NVDA Core 577 may change this a little bit later. Thanks.

From: Derek Riemer [mailto:notifications@github.com] Sent: Friday, July 21, 2017 8:10 AM To: dictationbridge/dictationbridge-nvda dictationbridge-nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: Re: [dictationbridge/dictationbridge-nvda] Refactor: allow Dictationbridge to copy custom commands to a dictation software of user's choosing, not just limited to Dragon (#5)

The problem is the user might only want to install one engines commands. @josephsl https://github.com/josephsl Are you happy with the current addons submenu approach?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dictationbridge/dictationbridge-nvda/issues/5#issuecomment-317027370 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkPSOVBHKOQEqjk4sf4wae_g6VBXoks5sQL9NgaJpZM4MEwhZ .

derekriemer commented 7 years ago

The implementation by @leonardder has the preferences menu still for addons to use. If all parties are happy with this, I'll close it.