Feature/export stock orders

[biodavidjm]

Incorporating the stock orders export for plasmids and strains

[biodavidjm]

cc: @cybersiddhu please,take a look. I have separated the stock orders for both plasmids and strains.

[cybersiddhu]

• I think we don't need a single stock order command, so only have the separate one and delete the the one that is not needed.
• All the files seemed to be in a single commit, unless you wrote the code in one shot. There also seemed to be some changes which is also not reflected in the commit messages. So, if you make changes from previous version make sure it is get reflected in the commit message.
• Both Modware::Export::Command::stockordersplasmids and stockorderstrains have some fundamental problems. Will give you some hint but you have to patch them to get in proper shape. They don't block execution but not written object oriented style and show improper use of language construct.
  • You have to call method not subroutine, so call them in object context.
  • $self variable should always be the object, it is being thoroughly molested in the code. Needless to say, you have to change that to proper perl convention.
  • If something is null/blank/empty or has no value, just check them and return. You don't need so many lines of code to do that or fill it up with fake value. Secondly you need to learn how to write perl way of checking empty value. Perl has lot of subtleties in this regard, so please spend some time in learning them.
  • The lack of idiomatic perl code always has a side effect of using extra parenthesis. If dealt properly, those will go away resulting in cleaner code. Anyway, you really need to spend (a lot i think) time to learn when and why parenthesis is used.

Plan B

Just delegate the null checking logic to the database itself, then you don't have to do that at application code.

[cybersiddhu]

Why is this closed without merging the code and double checking the unit tests ?