search

dictyBase / frontendx

BSD 2-Clause "Simplified" License
0 stars 0 forks source link

consolidate loader component #602

Open ktun95 opened 6 months ago

ktun95 commented 6 months ago

Existing Loader components in the codebase:

dicty-frontpage -> src/common/components/Loader.tsx dicty-frontpage -> src/features/About/SpecialThanks.tsx dicty-frontpage -> src/features/About/TechnicalSummary.tsx frontpage-components -> src/Loader.tsx auth -> src/LoadingDisplay.tsx resizable-image -> src/LoadingDisplay.tsx dicty-image -> src/LoadingDisplay.tsx ui-dsc -> src/LoadingDisplay.tsx

ktun95 commented 5 months ago

I think we should create a new package for common ui components across all of our applications, for loading displays, error displays, layouts, and anything else that is not specific to an application. Currently we have a package called frontpage-components, one called ui-dsc for dicty-stock-center, and ui user. It doesn't make sense to put a LoadingDisplay in any of these,

ktun95 commented 5 months ago

Create a generic loading component (or reuse an existing one).