search

diderot-edu / diderot-feedback

0 stars 0 forks source link

[Regression] Custom code block CSS is being clobbered #58

Closed ishantheperson closed 4 years ago

ishantheperson commented 4 years ago

In 15122 we had some custom CSS for the code listings. However, now it looks like some global stylesheet is overriding it: image

The .sourceCode selectors are clobbering our CSS. Technically we could fix this with !important everywhere but that's not a nice solution at all.

As a result the code blocks don't look nice at all: image

ishantheperson commented 4 years ago

@umutacar has this been resolved but not pushed to the production site?

umutacar commented 4 years ago

Yes, sorry github closes these automatically. It has not been deployed to production. I will deploy to staging and let you know so that you can look over it.

umutacar commented 4 years ago

this is deployed on staging. please let me know if it looks ok.

ishantheperson commented 4 years ago

@umutacar It doesn't work on the post office view e.g. if a student creates a post referencing an atom which has a code block, the code block is still not highlighted with the correct CSS: https://staging.diderot.one/courses/23/post-office/17259

umutacar commented 4 years ago

Ok good to know. The book looks good?

On Mon, Sep 14, 2020, 7:15 PM Ishan Bhargava notifications@github.com wrote:

It doesn't work on the post office view e.g. if a student creates a post referencing an atom which has a code block, the code block is still not highlighted with the correct CSS: https://staging.diderot.one/courses/23/post-office/17259

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diderot-edu/diderot-feedback/issues/58#issuecomment-692367330, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOJUHOBK6F7IWE3A2CNN5DSF2PYRANCNFSM4RECOYYQ .

ishantheperson commented 4 years ago

Looks fine in the book view.

umutacar commented 4 years ago

Ok good to know.

On Mon, Sep 14, 2020, 7:32 PM Ishan Bhargava notifications@github.com wrote:

Looks fine in the book view.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diderot-edu/diderot-feedback/issues/58#issuecomment-692372350, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOJUHLT3FJ7PXITSM5UV4LSF2RXPANCNFSM4RECOYYQ .

umutacar commented 4 years ago

Hopefully fixed (on production)